Plasma/libplasma2/API Review/ContainmentActions

From KDE Community Wiki
Revision as of 13:12, 25 February 2013 by Notmart (talk | contribs)

Related changes in ContainmentPrivate

localActionPlugins and globalActionsPlugins get removed, only plugin instances will stay here. all bookeeping of containmentActions will be kept in Corona, indicized by containmentType

Properties

All properties and invokables are removed.

Enums

ContainmentActionsSource goes, as the concept of source in general.

Constructors

as
Status Action Method
DONE Keep explicit ContainmentActions(QObject * parent);
DONE Keep ~ContainmentActions();
DONE Keep protected ContainmentActions(QObject *parent, const QVariantList &args);


Actions

as
Status Action Method
TO DO Remove virtual QAction *triggerableContextAction(); <{{{3}}}>
TO DO Rename void performNext() -> performNextAction() <{{{3}}}>
TO DO Rename void performPrevious() -> performPreviousAction() <{{{3}}}>
DONE Keep contextualActions() -> not invokable anymore


Bookeeping

as
Status Action Method
TO DO Remove void setSource(ContainmentActionsSource source); <{{{3}}}>
TO DO Remove ContainmentActionsSource source() const; <{{{3}}}>
TO DO Remove init() <{{{3}}}>
TO DO Remove configurationRequired() <{{{3}}}>
TO DO Remove protected setConfigurationRequired(bool) <{{{3}}}>
TO DO Remove signal configurationrequiredChanged() <{{{3}}}>
TO DO Remove dataEngine() <{{{3}}}>
DONE Keep void setContainment(Containment *newContainment);

{{FeatureDone|Keep| Containment *containment();

DONE Keep static QString eventToString(QEvent *event); check if can be removed, probably not

Metadata

as
Status Action Method
TO DO Remove QString name() const; <{{{3}}}>
TO DO Remove QString pluginName() const; <{{{3}}}>
TO DO Remove QString icon() const; <{{{3}}}>
TO DO Add KPluginInfo pluginInfo() const; <{{{3}}}>


Configuration

as
Status Action Method
DONE Keep config()
TO DO Virtual void restore(const KConfigGroup &config); <{{{3}}}>
DONE Keep virtual void save(KConfigGroup &config);
DONE Change Signature virtual QWidget *createConfigurationInterface(QWidget *parent); -> becomes void createConfigurationInterface(QWindow *parent)
TO DO Remove virtual void configurationAccepted(); <{{{3}}}>