Plasma/libplasma2/API Review/ContainmentActions: Difference between revisions

From KDE Community Wiki
Line 52: Line 52:
{{FeatureTodo|Remove| ContainmentActionsSource source() const;}}
{{FeatureTodo|Remove| ContainmentActionsSource source() const;}}
{{FeatureTodo|Remove| init()}}
{{FeatureTodo|Remove| init()}}
{{FeatureTodo|Remove| configurationRequired()}}
{{FeatureDone|Remove| configurationRequired()}}
{{FeatureTodo|Remove| protected setConfigurationRequired(bool)}}
{{FeatureDone|Remove| protected setConfigurationRequired(bool)}}
{{FeatureTodo|Remove| signal configurationrequiredChanged()}}
{{FeatureDone|Remove| signal configurationrequiredChanged()}}
{{FeatureDone|Remove| dataEngine()}}
{{FeatureDone|Remove| dataEngine()}}
{{FeatureDone|Keep| void setContainment(Containment *newContainment);}}
{{FeatureDone|Keep| void setContainment(Containment *newContainment);}}

Revision as of 13:33, 25 February 2013

Related Class: ContainmentActionsPluginConfig

Remove this class, that should never be used by library users anyways: merge functionality in Corona

Related Class: ContainmentPrivate

localActionPlugins and globalActionsPlugins get removed, only plugin instances will stay here. all bookeeping of containmentActions will be kept in Corona, indicized by containmentType

Properties

All properties and invokables are removed.

Enums

ContainmentActionsSource goes, as the concept of source in general.

Constructors

as
Status Action Method
DONE Keep explicit ContainmentActions(QObject * parent);
DONE Keep ~ContainmentActions();
DONE Keep protected ContainmentActions(QObject *parent, const QVariantList &args);


Actions

as
Status Action Method
TO DO Remove virtual QAction *triggerableContextAction(); <{{{3}}}>
TO DO Rename void performNext() -> performNextAction() <{{{3}}}>
TO DO Rename void performPrevious() -> performPreviousAction() <{{{3}}}>
DONE Keep contextualActions() -> not invokable anymore


Bookeeping

as
Status Action Method
TO DO Remove void setSource(ContainmentActionsSource source); <{{{3}}}>
TO DO Remove ContainmentActionsSource source() const; <{{{3}}}>
TO DO Remove init() <{{{3}}}>
DONE Remove configurationRequired()
DONE Remove protected setConfigurationRequired(bool)
DONE Remove signal configurationrequiredChanged()
DONE Remove dataEngine()
DONE Keep void setContainment(Containment *newContainment);
DONE Keep Containment *containment();
DONE Keep static QString eventToString(QEvent *event); check if can be removed, probably not

Metadata

as
Status Action Method
TO DO Remove QString name() const; <{{{3}}}>
TO DO Remove QString pluginName() const; <{{{3}}}>
TO DO Remove QString icon() const; <{{{3}}}>
TO DO Add KPluginInfo pluginInfo() const; <{{{3}}}>


Configuration

as
Status Action Method
DONE Keep config()
TO DO Virtual void restore(const KConfigGroup &config); <{{{3}}}>
DONE Keep virtual void save(KConfigGroup &config);
DONE Change Signature virtual QWidget *createConfigurationInterface(QWidget *parent); -> becomes void createConfigurationInterface(QWindow *parent)
TO DO Remove virtual void configurationAccepted(); <{{{3}}}>