Kexi/Junior Jobs/Small report improvements: Difference between revisions

From KDE Community Wiki
No edit summary
 
(12 intermediate revisions by 2 users not shown)
Line 10: Line 10:
{{Note|Pick one task from this list. Mark it with a [assigned to YOURNAME] tag. Create a bugs.kde.org entry especially for non-trivial improvements. See [[Calligra/Contributing a Patch|Contributing a Patch]].}}
{{Note|Pick one task from this list. Mark it with a [assigned to YOURNAME] tag. Create a bugs.kde.org entry especially for non-trivial improvements. See [[Calligra/Contributing a Patch|Contributing a Patch]].}}


#[unassigned][2.9] Add visible "value" property to all report elements. If an element has proper data source assignment, the value is ignored but otherwise it's displayed as "static" data. Example: value of boolean type for a check box
#[piggz][2.9] (review at [https://git.reviewboard.kde.org/r/120935/]) Add visible "value" property to all report elements. If an element has proper data source assignment, the value is ignored but otherwise it's displayed as "static" data. Example: value of boolean type for a check box.
#*Report XML element name: '''report:value'''.
#*For Image element, then "static-image" property seems to be acting as the value. Fix the following:
#*For Image element, then "static-image" property seems to be acting as the value. Fix the following:
#**Have the property even worked (or is there regression?), setting image file does not work (master 2.9)
#**Has the property ever worked (or is there regression?), setting image file does not work (master 2.9)
#**Fix the use of ":lastVisitedImagePath" - it is displayed in the dialog when you click the "..." button
#**Fix the use of ":lastVisitedImagePath" - it is displayed in the dialog when you click the "..." button
#**Replace it with "value" but still load "static-image" property when report is opened, and save as "static-image" property too (special case for backward compatibility)
#**Replace it with "value" but still load "static-image" property when report is opened, and save as "static-image" property too (special case for backward compatibility)
Line 21: Line 22:
#*In case of Image Box display "image (unbound)" centered text as in the Image form widget
#*In case of Image Box display "image (unbound)" centered text as in the Image form widget
#[unassigned][2.9] when inserting lines by single click, the object is too small.
#[unassigned][2.9] when inserting lines by single click, the object is too small.
#[unassigned][2.9] Rename visible caption of "Check" to "Check Box", "Web" to "Web Page"
#[done][https://git.reviewboard.kde.org/r/123699/]<strike>Rename visible caption of "Check" to "Check Box"[2.9], "Web" to "Web Page"[3.0]</strike>
#[unassigned][2.9] Improve appearance of report check box element of style "Dot", it currently looks like a radio button, what is misleading: [http://wstaw.org/m/2014/09/11/plasma-desktopoD2613.png]
#[unassigned][2.9] Improve appearance of report check box element of style "Dot", it currently looks like a radio button, what is misleading: [http://wstaw.org/m/2014/09/11/plasma-desktopoD2613.png]
#[unassigned][2.9] Improve appearance of check box in tabular view when the value is NULL and Required == false: [http://wstaw.org/m/2014/09/11/plasma-desktopTc2613.png] -- the "?" mark is misplaced a bit
#[unassigned][2.9] Improve appearance of check box in tabular view when the value is NULL and Required == false: [http://wstaw.org/m/2014/09/11/plasma-desktopTc2613.png] -- the "?" mark is misplaced a bit
#[unassigned][2.9] Tables allow to set "Required" property to false, what means NULL values are allowed. When this is used with fields of boolean type, NULL values are presented using question marks (see [http://wstaw.org/m/2014/09/11/plasma-desktopNx2613.png]). In a report based on this table, it's not possible to see difference between NULL and false value: [http://wstaw.org/m/2014/09/11/plasma-desktopbe2613.png]. A mockup of how it should look like: [http://wstaw.org/m/2014/09/11/plasma-desktopEl2613.png]. Details: this should not be the default behaviour. Instead: add "tristate" boolean property to the check box report element, false by default, caption == "Tristate". If "tristate" is true, "?" marks should be visible for NULL values *if* data source is assigned.
#[unassigned][2.9] Tables allow to set "Required" property to false, what means NULL values are allowed. When this is used with fields of boolean type, NULL values are presented using question marks (see [http://wstaw.org/m/2014/09/11/plasma-desktopNx2613.png]). In a report based on this table, it's not possible to see difference between NULL and false value: [http://wstaw.org/m/2014/09/11/plasma-desktopbe2613.png]. A mockup of how it should look like: [http://wstaw.org/m/2014/09/11/plasma-desktopEl2613.png]. Details: this should not be the default behaviour. Instead: add "tristate" boolean property to the check box report element, false by default, caption == "Tristate". If "tristate" is true, "?" marks should be visible for NULL values *if* data source is assigned.
#[unassigned][2.9] Use the dedicated data source combo box widget from forms 'data source' tab [http://wstaw.org/m/2014/09/11/plasma-desktopWj2613.png] in reports. The current data source combo in reports 'data source' tab has broken sorting and looks inferior [http://wstaw.org/m/2014/09/11/plasma-desktopqa2613.png] to what form offers. Also it does not offer keyboard access or completion.
#[unassigned][2.9] Use the dedicated data source combo box widget from forms 'data source' tab [http://wstaw.org/m/2014/09/11/plasma-desktopWj2613.png] in reports. The current data source combo in reports 'data source' tab has broken sorting and looks inferior [http://wstaw.org/m/2014/09/11/plasma-desktopqa2613.png] to what form offers. Also it does not offer keyboard access or completion.
#[unassigned][2.9] Change label for the data source combo in report designer's 'data source' tab from the hacky "Internal Source" to "Report's data source:" (making it similar to what forms shows).
#[done][3.0][https://git.reviewboard.kde.org/r/123699/]<strike>Change label for the data source combo in report designer's 'data source' tab from the hacky "Internal Source" to "Report's data source:" (making it similar to what forms shows).</strike>
#[unassigned][2.9] Improve HIG compliance. Change label related to the data source combo in form designer's 'data source' tab from "Form's data source" to "Form's data source:". Also in report designer's 'data source' tab change "Source Type:" to "Source Type:" and "External Source:" to "External source:".
#[done][3.0][https://git.reviewboard.kde.org/r/123699/]<strike>Improve HIG compliance. Change label related to the data source combo in form designer's 'data source' tab from "Form's data source" to "Form's data source:". Also in report designer's 'data source' tab change "Source Type:" to "Source type:" and "External Source:" to "External source:".</strike>
#[unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle where x1 > x2 or y1 > y2 fails. Element with default size is just inserted at (x1, x2). Add support for any combination of coordinates.
#[unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle where x1 > x2 or y1 > y2 fails. Element with default size is just inserted at (x1, x2). Add support for any combination of coordinates.
#[unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle misbehaves when user exceeds any border.
#[unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle misbehaves when user exceeds any border.
Line 45: Line 46:
#[unassigned][2.9] Replace "resize-mode" property of the Image report element with "scaled-contents" (bool) but still load  "resize-mode" property when report is opened, and save as  "resize-mode" property too (special case for backward compatibility), see similar property of Image Box form widget's for more info.
#[unassigned][2.9] Replace "resize-mode" property of the Image report element with "scaled-contents" (bool) but still load  "resize-mode" property when report is opened, and save as  "resize-mode" property too (special case for backward compatibility), see similar property of Image Box form widget's for more info.
#[unassigned][2.9] Add "keep-ratio" (bool) property to the Image report element, see similar property of Image Box form widget's for more info.
#[unassigned][2.9] Add "keep-ratio" (bool) property to the Image report element, see similar property of Image Box form widget's for more info.
#[unassigned][2.9] Add "background-color" (color) property to the Image report element, see similar property of Image Box form widget's for more info. Makes sense for images with alpha channels.
#[rwicik][2.9] Add "background-color" (color) property to the Image report element, see similar property of Image Box form widget's for more info. Makes sense for images with alpha channels.
#[unassigned][2.9] Add "horizontal-align" and "veritcal-align" (Qt::AlignmentFlag) properties to the Image report element, see similar properties of Image Box form widget's for more info.
#[unassigned][2.9] Add "horizontal-align" and "veritcal-align" (Qt::AlignmentFlag) properties to the Image report element, see similar properties of Image Box form widget's for more info.
#[unassigned][2.9] Check if all property names and values are translatable. Use any non-english language for this.
#[unassigned][2.9] Check if all property names and values are translatable. Use any non-english language for this.
#[unassigned][2.9] how m_image->m_resizeMode->setValue("Stretch") can work in krscriptimage.cpp?
#[unassigned][2.9] how m_image->m_resizeMode->setValue("Stretch") can work in krscriptimage.cpp?
#[unassigned][2.9] Kexi hangs in data view: assign table2.a to a checkbox in report6 (TODO(jstaniek): provide test file)
#[unassigned][2.9] {{Bug|340598}}: Reports are printed (and exported to PDF) in screen resolution (initial patch attached to the bug).
#[unassigned][2.9] Selecting entire report does not work for new unsaved report. Top reproduce: create a new report, report properties will be displayed. Then click on the Detail surface, Details properties will be displayed. Then click on the Report "box" (upper-left). Nothing changes.
#[unassigned][2.9] Selecting entire report should remove highlighting from the recently selected section. See [http://kexi-project.org/pics/2.9/bugs/kexi-report-bug-1.png].
#[unassigned][2.9] Qt::CrossCursor cursor appears only on inserting of element. It should be visible also for subsequent insertions.
#[jstaniek][2.9] <strike>Cut action should make the report design dirty.</strike>
#[unassigned][2.9] Section should not be shrink in the Design mode to a smaller area than required to display all. Example of the issue: [http://i.imgur.com/UVNfzbc.png]
#[unassigned][2.9] Section should be resized on loading the Design mode to area that is large enough so that all items are displayed. Example of the issue: [http://i.imgur.com/UVNfzbc.png]
#[unassigned][2.9] Invalid logic in selection across sections. Example for labels: 1. Insert Label1 into Detail, Label2 into the Report Footer. [http://i.imgur.com/GB2n094.png] 2. Click Label1 --> OK, it's selected. 3. Click Label2 --> It's selected. BUT: Issue #1: Label 1 is also selected (should be deselected) [http://i.imgur.com/jlDxsp1.png;] Issue #2: Detail section should be deactivated and Report Footer should be activated first, then Label2 should be selected. Issue #3: a consequence of above: delete/cut/copy does not work properly if section isn't selected properly. Currently user needs to click given section first and then select item, what's rather inconvenient workaround.

Latest revision as of 18:18, 9 May 2015

Status: some ASSIGNED, Target: 2.9, Difficulty: EASY

Proposed and mentored by Jstaniek (talk) 08:09, 11 September 2014 (UTC)

The Goal

Smaller but important improvements in Kexi Reports. Often related to usability.

The Tasks

Note

Pick one task from this list. Mark it with a [assigned to YOURNAME] tag. Create a bugs.kde.org entry especially for non-trivial improvements. See Contributing a Patch.


  1. [piggz][2.9] (review at [1]) Add visible "value" property to all report elements. If an element has proper data source assignment, the value is ignored but otherwise it's displayed as "static" data. Example: value of boolean type for a check box.
    • Report XML element name: report:value.
    • For Image element, then "static-image" property seems to be acting as the value. Fix the following:
      • Has the property ever worked (or is there regression?), setting image file does not work (master 2.9)
      • Fix the use of ":lastVisitedImagePath" - it is displayed in the dialog when you click the "..." button
      • Replace it with "value" but still load "static-image" property when report is opened, and save as "static-image" property too (special case for backward compatibility)
  2. [unassigned][2.9] improve the placeholders for elements in design mode: translate them too. ": field" is not quite good.
    • In general follow what is practiced in Kexi Forms
    • If there is "data source" property set, display it as text
    • If there is no "data source" property set but "value" property is set, display its representation
    • In case of Image Box display "image (unbound)" centered text as in the Image form widget
  3. [unassigned][2.9] when inserting lines by single click, the object is too small.
  4. [done][2]Rename visible caption of "Check" to "Check Box"[2.9], "Web" to "Web Page"[3.0]
  5. [unassigned][2.9] Improve appearance of report check box element of style "Dot", it currently looks like a radio button, what is misleading: [3]
  6. [unassigned][2.9] Improve appearance of check box in tabular view when the value is NULL and Required == false: [4] -- the "?" mark is misplaced a bit
  7. [unassigned][2.9] Tables allow to set "Required" property to false, what means NULL values are allowed. When this is used with fields of boolean type, NULL values are presented using question marks (see [5]). In a report based on this table, it's not possible to see difference between NULL and false value: [6]. A mockup of how it should look like: [7]. Details: this should not be the default behaviour. Instead: add "tristate" boolean property to the check box report element, false by default, caption == "Tristate". If "tristate" is true, "?" marks should be visible for NULL values *if* data source is assigned.
  8. [unassigned][2.9] Use the dedicated data source combo box widget from forms 'data source' tab [8] in reports. The current data source combo in reports 'data source' tab has broken sorting and looks inferior [9] to what form offers. Also it does not offer keyboard access or completion.
  9. [done][3.0][10]Change label for the data source combo in report designer's 'data source' tab from the hacky "Internal Source" to "Report's data source:" (making it similar to what forms shows).
  10. [done][3.0][11]Improve HIG compliance. Change label related to the data source combo in form designer's 'data source' tab from "Form's data source" to "Form's data source:". Also in report designer's 'data source' tab change "Source Type:" to "Source type:" and "External Source:" to "External source:".
  11. [unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle where x1 > x2 or y1 > y2 fails. Element with default size is just inserted at (x1, x2). Add support for any combination of coordinates.
  12. [unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle misbehaves when user exceeds any border.
  13. [unassigned][2.9] Inserting element by drawing a (x1, y2, x2, y2) rectangle select existing widgets the user draws over. This should not happen.
  14. Moving multiple selection isn't possible
  15. [unassigned][2.9] Multi-selection should also work when user presses left mouse button with Shift key. Another such click should unselect a widget.
  16. [unassigned][2.9] Pasted element(s) should be automatically selected, and previous selection should be cleared.
  17. [unassigned][2.9] Wish #339032 Add possibility of "Duplicating" current selection of report elements by dragging while Ctrl button is pressed. This already works in forms. Please visualize the dragging (in forms it's poorly visualized but the feature works). Duplicating is very similar to copy+paste. See an example for PowerPoint.
  18. [assigned to r.wicik][2.8] Change default for background color to Qt::transparent in report elements. Just change from Qt::white.
  19. [assigned to r.wicik][2.8] Change default for background color to foreground palette color in report elements. Just change from Qt::black.
  20. [assigned to r.wicik][2.8] "background-opacity" property not visible in report elements.
  21. [assigned to r.wicik][2.8] "background-color" property not visible in report elements in preview mode and printouts.
  22. [assigned to r.wicik][2.8] "foreground-color" property not visible in report elements in preview mode and printouts.
  23. [unassigned][2.9] Add "foreground-opacity" property to report elements.
  24. [assigned to MPtr][2.8] Add translation and hide some widget.
  25. [unassigned][2.9] Add "smoothing" (bool) property to the Image report element, see similar property of Image Box form widget's for more info.
  26. [unassigned][2.9] Replace "resize-mode" property of the Image report element with "scaled-contents" (bool) but still load "resize-mode" property when report is opened, and save as "resize-mode" property too (special case for backward compatibility), see similar property of Image Box form widget's for more info.
  27. [unassigned][2.9] Add "keep-ratio" (bool) property to the Image report element, see similar property of Image Box form widget's for more info.
  28. [rwicik][2.9] Add "background-color" (color) property to the Image report element, see similar property of Image Box form widget's for more info. Makes sense for images with alpha channels.
  29. [unassigned][2.9] Add "horizontal-align" and "veritcal-align" (Qt::AlignmentFlag) properties to the Image report element, see similar properties of Image Box form widget's for more info.
  30. [unassigned][2.9] Check if all property names and values are translatable. Use any non-english language for this.
  31. [unassigned][2.9] how m_image->m_resizeMode->setValue("Stretch") can work in krscriptimage.cpp?
  32. [unassigned][2.9] Kexi hangs in data view: assign table2.a to a checkbox in report6 (TODO(jstaniek): provide test file)
  33. [unassigned][2.9] Bug #340598: Reports are printed (and exported to PDF) in screen resolution (initial patch attached to the bug).
  34. [unassigned][2.9] Selecting entire report does not work for new unsaved report. Top reproduce: create a new report, report properties will be displayed. Then click on the Detail surface, Details properties will be displayed. Then click on the Report "box" (upper-left). Nothing changes.
  35. [unassigned][2.9] Selecting entire report should remove highlighting from the recently selected section. See [12].
  36. [unassigned][2.9] Qt::CrossCursor cursor appears only on inserting of element. It should be visible also for subsequent insertions.
  37. [jstaniek][2.9] Cut action should make the report design dirty.
  38. [unassigned][2.9] Section should not be shrink in the Design mode to a smaller area than required to display all. Example of the issue: [13]
  39. [unassigned][2.9] Section should be resized on loading the Design mode to area that is large enough so that all items are displayed. Example of the issue: [14]
  40. [unassigned][2.9] Invalid logic in selection across sections. Example for labels: 1. Insert Label1 into Detail, Label2 into the Report Footer. [15] 2. Click Label1 --> OK, it's selected. 3. Click Label2 --> It's selected. BUT: Issue #1: Label 1 is also selected (should be deselected) [16] Issue #2: Detail section should be deactivated and Report Footer should be activated first, then Label2 should be selected. Issue #3: a consequence of above: delete/cut/copy does not work properly if section isn't selected properly. Currently user needs to click given section first and then select item, what's rather inconvenient workaround.