Plasma/Tokamak1
< Plasma
API Reviews
Plasma::Theme
self() -> default() :NOTE: default is a C++ keyword, defaultTheme() perhaps?set application dies, use KGlobal insteadimplementation note: Theme::Private::config() shouldn't open config everytimeimage() -> imagePath()colors() -> KColorScheme colorScheme()color methods -> color(ColorRole) (enum)font methods -> font(RontRole) (enum)compositingActive -> windowTranslucencyEnabled (out of place?)changed() -> themeChanged()slots -> Q_PRIVATE_SLOT
Plasma::Corona
Remove constructor with size parametersRemove isKioskImmutable() -> protectedisImmutable() setIsImmutable() and isKioskImmutable() became immutability() and setImmutability()remove maxSizeHintloadDefaultSetup protected and loadDefaultLayoutclearApplets -> clearContainmentsconfig -> private Note : config protected in containments and applets
Note: remaining public for now applet needs it for Applet::globalConfig()
load/save applets -> load/save LayoutsscheduleConfigSync -> privateaddContainment not a slot ->splitaddContainment(id, delayedFlag) [private]addContainment() [public]
containmentFor screen -> Not slotcontainments() not a slotlaunchActivated -> to plasmaappscreenOwnerChanged -> to plasmaapp
Note: it's not really desktop specific, so will stay here
protected slots -> private
Terminology : layouts = Applets + containments organization
Plasma::Widget
deletion- Create a tooltip manager
Plasma::Svg
ContentType -> kill change methods using it to take bool and change their names to containsMultiplesImages (hmm actually not understood what this means :D)elementRect -> return a QRectFelementExists -> hasElementmatrixForElement -> privatesize -> group with resizemove private slots to a pimpl
Plasma::PanelSvg
should inherits of Plasma::SvgdrawXborder -> XbordercontentAtOrigin -> separate bool propertySvgPanel(path,parent) -> SvgPanel(parent)setFile + file() -> setImagePath + imagePath() NOTE : same modification in svg and theme classessetBorderFlags + borderFlags() -> setEnabledBorders + enabledBordersadd resize(x,y)setPrefix ->setElementsPrefixupdateSizes() -> Q_PRIVATE_SLOTpos + setPos died -> pos added to paintsetLocation() -> setElementPrefix(enum)location() -> died
Plasma::Applet
remainSquare()+setAspectRatioMode()->merge using our own aspect ratio mode enun- category()+name()+pluginName() dies->replaced by pluginInfo()
<!> pluginInfo() should return a hand-made KPluginInfo if id->appletDescription isValid()
resetConfigurationObject()->pimplwatchForMouseMove()-> ??? (the suggested registerDragHandles is a very bad name)protected setBackgroundHints() + public backgroundHings() const;as a result (set)DrawStandardBackground() dies
Note: being protected AppletScript can't change it anymore: AppletScript friend of Applet?
(set)configNeeded()->(is|set)ConfigurationRequired()+set protectedshape() dies*Opacity() dieslaunchActivated()-> releaseVisualFocus()configXml() -> configScheme()contextActions()->const+contextualActions()inherits QGraphicsWidgetinit()->protecgted+Corona::loadLayout() is friendconfig() methods->protected.globalConfig()->protected
Note: It has been decided the above two functions will remain public because if an applet uses an external QWidget it will have to access the configuration of the applet
constraintUpdated()->constraintEvent()+protected
Note: check again corona for events like methods
formFactors()->non virtual + get the containment impl there
==>Plasma::Containment::Private inherits Plasma::Applet::Private
location-> Plasma::Containment::PrivateknownApplets()->listAppletInfo()knownAppletsForMimetype()->listAppletInfoForMimeType()knownCategories()->listCategories()
Note: known*()->list*()
because of load(), ctors->protected
Note: containment wants to construct an Applet directly when creates the one with the failed to launch error message, but even if it's friend of applet it does that in the dptr, and this somewhere compiles somewhere not, generally not good.
color() die! die! die!isKioskmmutable()->pimplisImmutable() setIsImmutable() and isKioskImmutable() became immutability() and setImmutability()failedtoLaunch()->hasfailedToLaunch()setFailedToLaunch()->protectedhasCofigurationInterface()-> constsetHasConfigurationInterface()->protectedkill *StandardBackground()+*ShadowShown()
->enum BackgroundHint {NoBackground=0, StandardBackground, ShadowedBackground} +QFlag
set(is)containment()->set(ActsAs)Containment()+setter is protectedraise()->slot+addlower()requestFocus() diesshowConfigurationInterface()->nonvirtualcreateconfigurationInterface()->virtual protected, not slotFlush UpdatedConstraints()->Flush PendingCostraintEvents()ThemeChanged()->Q_PRIVATE_SLOTglobalName(), instanceName()->pimplwatchForFocus()->diesneedFocus()->diestopLeft()->diescheckImmutability()->Q_PRIVATE_SLOT
Plasma::Containments(aseigo)
- addToolBoxTool() -> addToolBoxAction(action)
- add removeToolBoxAction(action)
formfactor() & location() in AppletsetFormFactor() & setLocation() in ContainmentStyleOption::desktop diesList, Dict diesCustomContainment = 127setContainmentType() -> protectedsetIsContainment() -> dies (meat in applet)known...() -> list...()addApplet() -> splitaddApplet(name, args, point, size) [public]addApplet(name, args, point, size, id, delayedinit) [private]
indexAt() dies, add QPointF to appletAdded()setScreen() & screen() & effectiveScreenPos() -> diewill remain due to PUI relevance - aseigo(save|load)Constraints() -> pimplemitLaunchActivated() -> see Applet, maybe not publiccontainmentConstraingUpdated() -> pimpladd setToolBoxExpanded(bool) slot(show|hide)ToolBox() -> (expand|unexpand)ToolBox()launchActivated() -> see AppletzoomIn() & zoomOut() signals -> zoomRequested(containment, direction enum)showAddWidgets() -> showAddWidgetsInterface(QPointF)screenChanged() -> dies (move to plasma app ScreenManager)toggleDesktopImmutability() -> Q_PRIVATE_SLOTzoomIn() -> Q_PRIVATE_SLOTcreateLayout() -> diesprotected slots (except dropEvent()) & private slots & methods ->pimpl & Q_PRIVATE_SLOT
Plasma::DataEngine
sourceDict() -> containerDict()engineName() -> name() + add protected setName()connectSource() -> updateInterval -> pollingIntervalconnectAllSources() -> updateInterval -> pollingIntervalref() & deref() & isUsed() -> privatesetIcon() -> protectednewSource -> sourceAdded()sourceRequested -> sourceRequestEvent()updateSource() -> updateSourceEvent()setData() -> SHALL NOT remove source (fix APIDOX)clearData() -> removeAllData()setSourceLimit() -> DIE! DIE! DIE!clearSources() -> removeAllSources()checkForUpdates() -> scheduleSourcesUpdated()internalUpdateSource() -> Q_PRIVATE_SLOT
Plasma::DataEngineManager
ctor+dtor privateknownEngines()->listAllEngines()get()->engine()(un)load()->(un)loadEngine()
Plasma::DataContainer
clearData()->removeAllData()checkForUpdate()->protectedint timeSinceLastUpdate()->protected+return uinthasUpdates()->pimplsetNeedsUpdate()->pimplcheckUsage()->pimplconnectVisualization()->not slotunused()->becameUnused()requestUpdate()->updateRequested()
Plasma::View
(set)DrawWallpaper() -> (set|is)WallpaperEnabled()(set)Screen() -> plasma appgoing to leave this here, as the screen management is not manditory, but useful for any PUI - aseigo(set)Desktop() -> plasma appgoing to leave this here, as the screen management is not manditory, but useful for any PUI - aseigoeffectiveDesktop -> plasma appgoing to leave this here, as the screen management is not manditory, but useful for any PUI - aseigoconfig() -> protectedupdateSceneRect() -> Q_PRIVATE_SLOTinitGraphicsView() -> pimpl
Plasma::AbstractRunner
SlowSpeed before NormalSpeedload() -> loadAll()+ load() no = QString() for whitelistctors -> protectedconfg() -> protected- match() -> protected
(set)hasMatchOptions() -> (set)hasRunOptions()-> (set)hasExecOptions()? (proposed by bettio)createMatchOptions() -> createRunOptions()-> createExecOptions()? (proposed by bettio)runnerName() -> name()- init() -> Q_PRIVATE_SLOT
Plasma::SearchContext
- switch to value based for matches too
- matchesChanged() emitted from performMatch()
resetSearchTerm(QString) -> reset()mimetype() -> mimeType()addMatchesTo() -> copyMatchesTo() (copy -> move)- determineType() -> pimpl
clearMatches() -> removeAllMatches()
Plasma runner terminology
Plasma::SearchContext => Plasma::RunnerContextPlasma::SearchMatch => Plasma::QueryMatchIn the RunnerContext, RunnerResult and AbstractRunner APIs:
* search term => query
Plasma::Phase -> Plasma::Animator
Animation merges with ElementAnimation -> AppearAnimation,DisappearAnimation,ActivateAnimationSlideInMovement,SlideOutMovement,FastSlideInMovement, FastSlideOutMovementAnimId dies -> use intconstructor + destructor privateanimateItem, moveItem return intadd stopItemAnimation(int)animationCompleted() -> animationFinished()same for others signalprotected slots -> Q_PRIVATE_SLOTinit -> pimplsetAnimationPixmap -> setInitialPixmapanimationResult() -> currentPixmap
Plasma::AnimationDriver
FramesPerSeconds -> animationFramesPerSeconds, elementAnimationFramesPerSeconds,movementAnimationFramesPerSecondssame for duration and curveappear -> itemAppeardisappear -> itemDisappearactivate -> itemActivatedslide -> itemSlideelementX -> should use progress, not frame
Plasma::GlApplet
makeCurrent -> pimpl: actually, this is required to be public - aseigo
Plasma::Delegate
(Marco Martin)
- *columnType* -> device notifier
Needed for the delegate to know he must draw an icon smaller than the main one
ctor should have parent paramconstants ->pimplprotected non virtual-> pimpl
The protected methods are needed only by subclasses to know where to paint so they are still needed
setRole()->setRoleMapping(QMap) + add roleMapping() getter- fixme: copy rhs of whiteboard (missing)
Plasma::Dialog
(Ménard Alexis)
themeUpdated -> Q_PRIVATE_SLOT
Plasma::AppletBrowserWidget
remove containment from constructorprotected slots -> Q_PRIVATE_SLOTSprivate methods -> pimpl
Plasma::AppletBrowser
remove containment from constructor
NOTE : AppletBrowser and AppletBrowserWidget should be in different .h
Plasma::PackageMetadata
isComplete -> isValidwrite() -> remove icon parameter
Plasma::PackageStructure(josebur)
- must not inherits of QObject
- QList<char *> -> QStringList
- const char * -> QString
required -> isRequired()- (set)(Default)Mimetypes -> (set)(Default)Mimetypes ??
uninstallPackage -> packageName instead of param packagepathChanged -> died- Xtypes() -> XFormat()
Plasma::Package(josebur)
- const char * -> QString
knownPackages -> listInstalledinstallPackage -> installleave itregisterPackage -> registerKeyword! leave itcreatePackage -> createleave it- Missing uninstall
Plasma::ScriptEngine
contructor -> protectedprotected slots -> not slots- knowLanguages -> getScriptApis() ??
- loadScriptEngine() -> language param become a scriptAPI
- add version number to loading
Plasma::AppletScript
contentSizeHint -> diedconstraintsUpdated -> constraintsEventcontextActions -> contextualActions- change the K_EXPORT stuff to support several plugins by lib
Plasma::RunnerScript
- change to new runner API
protected slots -> not slots
Plasma::DataEngineScript
Change to new API
- Get QScript script bindings loading
- QScript Runners
- Cool scripting demo
- Webkit
- Default set of components for 4.1
- Clock applet library (and how to do that for other categories of applets)
- Improve existing applets
- Write new applets and engines
- Panel and panel config saner/pretification
- Kickoff UI
- Applet handles
- WoC
- Video in plasma
- Extenders
- System tray applet
- Keyboard shortcuts
- Plasma::Service
- Usability review
- Documentation
- Runtime
- Dev
- User
- Top level window physics
- Plasmoid grouping
- Plasma configuration UI
- Devices
- API review
- Generic webservice support
- Theming
- KIcon issues
- tooltip love (flickering, hiding..)
- krunner looks
- lock desktop work properly
- use createConfigurationInterface
- panel toolbox
- panel hiding
- twitter improvements
- Phase::Animator
- theme installation from files