Plasma/libplasma2/API Review/Theme: Difference between revisions

From KDE Community Wiki
 
(4 intermediate revisions by one other user not shown)
Line 11: Line 11:


{{FeatureDone|Keep| explicit Theme(QObject *parent ); will create the standard "global" theme}}
{{FeatureDone|Keep| explicit Theme(QObject *parent ); will create the standard "global" theme}}
{{FeatureInProgress|Keep|  explicit Theme(const QString &themeName, QObject *parent ); -> will create a "custom" theme}}
{{FeatureDone|Keep|  explicit Theme(const QString &themeName, QObject *parent ); -> will create a "custom" theme}}
{{FeatureDone|Keep| ~Theme();}}
{{FeatureDone|Keep| ~Theme();}}


Line 25: Line 25:


{{FeatureDone|Keep| ColorRole}}
{{FeatureDone|Keep| ColorRole}}
{{FeatureTodo|Remove| FontRole}}
{{FeatureDone|Remove| FontRole}}


|}
|}


=Fonts=
=Fonts=
Line 38: Line 37:
! Method  
! Method  


{{FeatureTodo|Remove| void setFont(const QFont &font, FontRole role);}}
{{FeatureDone|Remove| void setFont(const QFont &font, FontRole role);}}
{{FeatureTodo|Remove| QFont font(FontRole role) const;}}
{{FeatureDone|Remove| QFont font(FontRole role) const;}}
{{FeatureTodo|Remove| QFontMetrics fontMetrics() const;}}
{{FeatureDone|Remove| QFontMetrics fontMetrics() const;}}


|}
|}
Line 52: Line 51:
! Method  
! Method  


{{FeatureTodo|Remove| static Theme *defaultTheme(); -> the dpointer will be implicitly shared: if a theme is created with a different name a new dpointer is created.}}
{{FeatureDone|Remove| static Theme *defaultTheme(); -> the dpointer will be implicitly shared: if a theme is created with a different name a new dpointer is created.}}
{{FeatureDone|Keep| void setThemeName(const QString &themeName);}}
{{FeatureDone|Keep| void setThemeName(const QString &themeName);}}
{{FeatureDone|Keep| QString themeName() const;}}
{{FeatureDone|Keep| QString themeName() const;}}
Line 64: Line 63:
{{FeatureTodo|Rename| bool useGlobalSettings() const; -> QString configurationGroupName() const; '''Note''': store config group name in the KConfigGroup object in the dptr}}
{{FeatureTodo|Rename| bool useGlobalSettings() const; -> QString configurationGroupName() const; '''Note''': store config group name in the KConfigGroup object in the dptr}}
{{FeatureDone|Remove| bool useNativeWidgetStyle() const;}}
{{FeatureDone|Remove| bool useNativeWidgetStyle() const;}}
{{FeatureTodo|Move?| QString styleSheet(const QString &css) const; -> SVG stylesheet becomes private
{{FeatureDone|Move| QString styleSheet(const QString &css) const; -> SVG stylesheet becomes private
cachedStyleSheets -> does not need to be a QHash, we only ever have 2 stylesheets cached
cachedStyleSheets -> does not need to be a QHash, we only ever have 2 stylesheets cached
See if there are any uses of custom stylesheets being processed by this (to see if we need the css parameter at all)}}
See if there are any uses of custom stylesheets being processed by this (to see if we need the css parameter at all)}}
Line 79: Line 78:
{{FeatureDone|Remove|  int toolTipDelay() const;}}
{{FeatureDone|Remove|  int toolTipDelay() const;}}
{{FeatureDone|Keep| SIGNAL void themeChanged();}}
{{FeatureDone|Keep| SIGNAL void themeChanged();}}
{{FeatureTodo|Move| public slot void settingsChanged(); -> becomes private, goes into dpointer}}
{{FeatureDone|Move| public slot void settingsChanged(); -> becomes private, goes into dpointer}}


|}
|}

Latest revision as of 23:03, 12 March 2014

Properties and invokables

All removed, only declared in the subclass in the QML bindings

Constructors

Status Action Method
DONE Keep explicit Theme(QObject *parent ); will create the standard "global" theme
DONE Keep explicit Theme(const QString &themeName, QObject *parent ); -> will create a "custom" theme
DONE Keep ~Theme();


Enums

Status Action Method
DONE Keep ColorRole
DONE Remove FontRole


Fonts

Status Action Method
DONE Remove void setFont(const QFont &font, FontRole role);
DONE Remove QFont font(FontRole role) const;
DONE Remove QFontMetrics fontMetrics() const;


Other methods

Status Action Method
DONE Remove static Theme *defaultTheme(); -> the dpointer will be implicitly shared: if a theme is created with a different name a new dpointer is created.
DONE Keep void setThemeName(const QString &themeName);
DONE Keep QString themeName() const;
DONE Keep QString imagePath(const QString &name) const;
DONE Keep bool currentThemeHasImage(const QString &name) const;
DONE Keep QString wallpaperPath(const QSize &size) const;
DONE Keep KSharedConfigPtr colorScheme() const;
DONE Keep QColor color(ColorRole role) const;
DONE Remove bool windowTranslucencyEnabled() const;
TO DO Rename void setUseGlobalSettings(bool useGlobal); -> void setConfigurationGroupName(const QString &name); <{{{3}}}>
TO DO Rename bool useGlobalSettings() const; -> QString configurationGroupName() const; Note: store config group name in the KConfigGroup object in the dptr <{{{3}}}>
DONE Remove bool useNativeWidgetStyle() const;
DONE Move QString styleSheet(const QString &css) const; -> SVG stylesheet becomes private

cachedStyleSheets -> does not need to be a QHash, we only ever have 2 stylesheets cached See if there are any uses of custom stylesheets being processed by this (to see if we need the css parameter at all)

DONE Keep bool findInCache(const QString &key, QPixmap &pix, unsigned int lastModified);
DONE Keep void insertIntoCache(const QString& key, const QPixmap& pix);
DONE Keep void insertIntoCache(const QString& key, const QPixmap& pix, const QString& id);
DONE Keep void setCacheLimit(int kbytes);
DONE Keep bool findInRectsCache(const QString &image, const QString &element, QRectF &rect) const;
DONE Keep QStringList listCachedRectKeys(const QString &image) const;
DONE Keep void insertIntoRectsCache(const QString& image, const QString &element, const QRectF &rect);
DONE Keep void invalidateRectsCache(const QString &image);
DONE Keep void releaseRectsCache(const QString &image);
DONE Rename QUrl homepage() const; -> KPluginfo pluginInfo();
DONE Remove int toolTipDelay() const;
DONE Keep SIGNAL void themeChanged();
DONE Move public slot void settingsChanged(); -> becomes private, goes into dpointer