Plasma/libplasma2/API Review/Containment

From KDE Community Wiki
Revision as of 14:35, 18 February 2013 by Notmart (talk | contribs)

Q_PROPERTIES

All qproperties and invokables must go

Enums

Type probably goes in plasma.h

       enum Type {
           NoContainmentType = -1,  /**< @internal */
           DesktopContainment = 0,  /**< A desktop containment */ New name -> suggestions [ Canvas ]
           PanelContainment,        /**< A desktop panel */
           CustomContainment = 127, /**< A containment that is neither a desktop nor a panel
                                       but something application specific */
          CustomPanelContainment = 128 /**< A customized desktop panel */
       };

ToolType goes in plasma.h it becomes ActionType (not related to toolbox anymore)

       enum ToolType {
           AddTool = 0,
           ConfigureTool = 100,
           ControlTool = 200,
           MiscTool = 300,
           DestructiveTool = 400,
           UserToolType = DestructiveTool + 1000
       };
       Q_ENUMS(ToolType)

Bookkeeping

as
Status Action Method
TO DO Rename Applet *addApplet(const QString &name, const QVariantList args, const QRectF geometry ; -> becomes createApplet, args and geometry arguments go away <{{{3}}}>
TO DO Paramenters void addApplet(Applet *applet, const QPointF pos); -> pos parameter goes <{{{3}}}>
DONE Keep QList<Applet *> applets() const;
TO DO Remove void clearApplets(); <{{{3}}}>
TO DO Paramenters void setScreen(int screen, int desktop); -> remove desktop <{{{3}}}>
DONE Keep int screen() const;
TO DO Remove int lastScreen() const; <{{{3}}}>
TO DO Remove int desktop() const; <{{{3}}}>
TO DO Remove int lastDesktop() const; <{{{3}}}>


Constructors

as
Status Action Method
DONE Keep explicit Containment(QObject *parent , const QString &serviceId , uint containmentId );
DONE Keep Containment(QObject *parent, const QVariantList &args);
DONE Keep ~Containment();


Plugin loading

as
Status Action Method
TO DO PluginLoader static KPluginInfo::List listContainments(const QString &category, const QString &parentApp); <{{{3}}}>
TO DO PluginLoader static KPluginInfo::List listContainmentsOfType(const QString &type, const QString &category , const QString &parentApp ); <{{{3}}}>
TO DO PluginLoader static QStringList listContainmentTypes(); <{{{3}}}>
TO DO PluginLoader static KPluginInfo::List listContainmentsForMimeType(const QString &mimeType); <{{{3}}}>


Configuration

as
Status Action Method
DONE Keep void save(KConfigGroup &group) const;
DONE Keep void restore(KConfigGroup &group);
DONE Keep protected virtual void saveContents(KConfigGroup &group) const;
DONE Keep protected virtual void restoreContents(KConfigGroup &group);