PIM/MS Windows/SQLite Folder Indices/merge: Difference between revisions

From KDE Community Wiki
No edit summary
No edit summary
Line 13: Line 13:
*folderstorage.h
*folderstorage.h


*kmailicalifaceimpl.cpp
*kmailicalifaceimpl.cpp - OK
void KMailICalIfaceImpl::readConfig() - added sanity check:<code>
if ( !mCalendar || !mTasks || !mJournals || !mContacts || !mNotes )
  return;
</code>
KMFolder* KMailICalIfaceImpl::initFolder( KMail::FolderContentsType contentsType ) - added check for result of open():<code>if ( 0 != folder->open( "ifacefolder" ) ) { ....
</code>
 


*kmfolder.cpp
*kmfolder.cpp

Revision as of 09:18, 8 May 2008

Validation of the SQLite folder indices merge into kdepim trunk (805075).

Notes

  • "OK" means files or methods inspected in every detail.
  • We do not mention changes that only add/remove kDebug(), etc.

Results

  • compactionjob.cpp - OK
    • void MboxCompactionJob::done( int rc ): the only addition result of KDE_rename() is checked, return immediately on failure
  • folderstorage.cpp
  • folderstorage.h
  • kmailicalifaceimpl.cpp - OK

void KMailICalIfaceImpl::readConfig() - added sanity check: if ( !mCalendar || !mTasks || !mJournals || !mContacts || !mNotes )

 return;

KMFolder* KMailICalIfaceImpl::initFolder( KMail::FolderContentsType contentsType ) - added check for result of open():if ( 0 != folder->open( "ifacefolder" ) ) { ....


  • kmfolder.cpp
  • kmfolder.h
  • kmfolderdir.cpp
  • kmfolderindex.cpp
  • kmfolderindex.h
  • kmfoldermaildir.cpp
  • kmfoldermbox.cpp
  • kmfoldersearch.cpp
  • kmheaders.cpp
  • kmheaders.h
  • kmkernel.cpp
  • kmmsgbase.cpp
  • kmmsgbase.h
  • kmmsgdict.cpp
  • kmmsginfo.cpp
  • kmmsginfo.h
  • messageproperty.cpp - OK
    • minor optimizations only added, for example 1. instead of 2.:
      1. QMap<quint32, QPointer<KMFolder> >::ConstIterator it = sFolders.constFind( serNum );
        return it == sFolders.constEnd() ? 0 : (*it).operator->();
      2. if (sFolders.contains(serNum))
          return sFolders[serNum].operator->();
        return 0;
    • Affected methods:
      • KMFolder* MessageProperty::filterFolder( quint32 serNum ) - Status: OK
      • ActionScheduler* MessageProperty::filterHandler( quint32 serNum ) - Status: OK
      • bool MessageProperty::transferInProgress( quint32 serNum ) - Status: OK
      • void MessageProperty::setTransferInProgress( quint32 serNum, bool transfer, bool force ) - Status: OK
      • quint32 MessageProperty::serialCache( const KMMsgBase *msgBase ) - Status: OK