KDE Games/Git Conversion Progress: Difference between revisions

Revision as of 02:29, 5 March 2012

Once you've written the rules for a particular game and feel they're complete, push them to the kdegames directory of the kde-ruleset repository. Add your initials in the "Rules" column as a link pointing to the rules file.
Once you've generated a repository from the rules and verified its correctness, push it some place public, preferably a personal scratch repo. Add your initials in the "Repo" column as a link pointing to the repository webpage.

It is assumed that the rule writer has already verified the correctness of the repository, so don't bother adding yourself to the table.
Checkout the repository, poke around a bit and then perform each of the following checks, adding your initials in each column. Ideally, more than one person should check each repo, in which case, separate each set of initials with a comma.

Check1: The complete history is present. The first commit should be the initial import into KDE's CVS or SVN. All transitions from playground, kdereview, extragear, KDE3, etc. should be present.
Check2: The user documentation is in a subdirectory named "doc". The history of the doc folder should match that of the "kdegames/doc/<game>" folder.
Check3: Commit messages contain the original SVN path and revision numbers. (--add-metadata was used during conversion.)
Check4: The repository has only one head. (git branch -r) Two heads mean a broken master branch.
Check5: All relevant stable branches are present. If a game entered the kdegames module for the 4.3 release, it should have a stable branch "KDE/4.x" for each x >= 3 and none for x < 3.
Check6: All relevant release tags are present. If a game entered the kdegames module for the 4.3 release, it should have tags "KDE/4.x.y" for each x >= 3 and none for x < 3.
Check7: All stable branches are of the format "KDE/X.Y" and all release tags are of the format "vX.Y.Z".
Check8: If the game has a non-linear history (i.e. work branches were created and later merged back in to trunk) that should be recreated in the Git history. This is by far the most difficult check. Use git gui to visualise branches and merges, but you have to know what you're looking for. Fortunately, this isn't required for games that have a simple playground -> kdereview -> kdegames history.

@@ Line 14: / Line 14: @@
 ; Check1 : The complete history is present. The first commit should be the initial import into KDE's CVS or SVN. All transitions from playground, kdereview, extragear, KDE3, etc. should be present.
-; Check2 : The user documentation is in a subdirectory named "doc".
+; Check2 : The user documentation is in a subdirectory named "doc". The history of the doc folder should match that of the "kdegames/doc/<game>" folder.
 ; Check3 : Commit messages contain the original SVN path and revision numbers. (--add-metadata was used during conversion.)
 ; Check4 : The repository has only one head. (git branch -r) Two heads mean a broken master branch.