Plasma/libplasma2/API Review/Theme

Properties and invokables

All removed, only declared in the subclass in the QML bindings

Constructors

Status	Action	Method
DONE	Keep	explicit Theme(QObject *parent ); will create the standard "global" theme
IN PROGRESS	Keep	explicit Theme(const QString &themeName, QObject *parent ); -> will create a "custom" theme
DONE	Keep	~Theme();

Enums

Status	Action	Method
DONE	Keep	ColorRole
TO DO	Remove	FontRole	<{{{3}}}>

Fonts

Status	Action	Method
TO DO	Remove	{{{2}}}	<{{{3}}}>
TO DO	Remove	QFont font(FontRole role) const;	<{{{3}}}>
TO DO	Remove	QFontMetrics fontMetrics() const;	<{{{3}}}>

Other methods

Status	Action	Method
TO DO	Remove	static Theme *defaultTheme(); -> the dpointer will be implicitly shared: if a theme is created with a different name a new dpointer is created.	<{{{3}}}>
DONE	Keep	void setThemeName(const QString &themeName);
DONE	Keep	QString themeName() const;
DONE	Keep	QString imagePath(const QString &name) const;
DONE	Keep	bool currentThemeHasImage(const QString &name) const;
DONE	Keep	QString wallpaperPath(const QSize &size) const;
DONE	Keep	KSharedConfigPtr colorScheme() const;
DONE	Keep	QColor color(ColorRole role) const;
DONE	Keep	bool windowTranslucencyEnabled() const;
TO DO	Rename	void setUseGlobalSettings(bool useGlobal); -> void setConfigurationGroupName(const QString &name);	<{{{3}}}>
TO DO	Rename	bool useGlobalSettings() const; -> QString configurationGroupName() const; Note: store config group name in the KConfigGroup object in the dptr	<{{{3}}}>
TO DO	Remove	bool useNativeWidgetStyle() const;	<{{{3}}}>
TO DO	Move?	QString styleSheet(const QString &css) const; -> SVG stylesheet becomes private cachedStyleSheets -> does not need to be a QHash, we only ever have 2 stylesheets cached See if there are any uses of custom stylesheets being processed by this (to see if we need the css parameter at all)	<{{{3}}}>
DONE	Keep	bool findInCache(const QString &key, QPixmap &pix, unsigned int lastModified);
DONE	Keep	void insertIntoCache(const QString& key, const QPixmap& pix);
DONE	Keep	void insertIntoCache(const QString& key, const QPixmap& pix, const QString& id);
DONE	Keep	void setCacheLimit(int kbytes);
DONE	Keep	bool findInRectsCache(const QString &image, const QString &element, QRectF &rect) const;
DONE	Keep	QStringList listCachedRectKeys(const QString &image) const;
DONE	Keep	void insertIntoRectsCache(const QString& image, const QString &element, const QRectF &rect);
DONE	Keep	void invalidateRectsCache(const QString &image);
DONE	Keep	void releaseRectsCache(const QString &image);
TO DO	Rename	QUrl homepage() const; -> KPluginfo pluginInfo();	<{{{3}}}>
DONE	Remove	int toolTipDelay() const;
DONE	Keep	SIGNAL void themeChanged();
TO DO	Move	public slot void settingsChanged(); -> becomes private, goes into dpointer	<{{{3}}}>