View source for Plasma/libplasma2/API Review/RunnerManager

{| cellspacing="0" cellpadding="5" border="1" style="border: 1px solid gray; border-collapse: collapse; text-align: left; width: 100%;" class="sortable"
|- style="background: rgb(236, 236, 236) none repeat scroll 0% 0%; -moz-background-clip: border; -moz-background-origin: padding; -moz-background-inline-policy: continuous; white-space: nowrap;"

! Status 
! Action 
! Method 

{{FeatureDone|Keep| explicit RunnerManager(QObject *parent);}}
{{FeatureTodo|Remove?| explicit RunnerManager(KConfigGroup &config, QObject *parent); <- don’t like it much, but probaly the cleanest way, (alternative would be init())}}
{{FeatureDone|Keep| ~RunnerManager();}}
{{FeatureDone|Keep|  AbstractRunner *runner(const QString &name) const;}}
{{FeatureTodo|Subclass| AbstractRunner *singleModeRunner() const; -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}
{{FeatureTodo|Subclass| void setSingleModeRunnerId(const QString &id); -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}
{{FeatureTodo|Subclass| QString singleModeRunnerId() const; -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}
{{FeatureTodo|Subclass| bool singleMode() const; -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}
{{FeatureTodo|Subclass| void setSingleMode(bool singleMode); -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}
{{FeatureTodo|Subclass| QStringList singleModeAdvertisedRunnerIds() const; -> should Single runner mode stuff go into a SingleModeRunnerManagersubclass?}}

{{FeatureTodo|Move| QString runnerName(const QString &id) const;->use KpluginInfo}}
{{FeatureDone|Keep| QList<AbstractRunner *> runners() const;}}
{{FeatureTodo|Review RunnerContext| RunnerContext *searchContext() const;}}

{{FeatureDone|Keep| QList<QueryMatch> matches() const;}}
{{FeatureDone|Keep| void run(const QueryMatch &match);}}
{{FeatureDone|Keep| void run(const QString &matchId);}}
{{FeatureDone|Keep| QList<QAction*> actionsForMatch(const QueryMatch &match);}}
{{FeatureDone|Keep| QString query() const;}}

{{FeatureTodo|Slot|void reloadConfiguration();-> not that nice having it exposed, but should be a slot}}

{{FeatureDone|Keep| void setAllowedRunners(const QStringList &runners);}}
{{FeatureDone|Keep|  QStringList allowedRunners() const;}}

{{FeatureTodo|Move| void loadRunner(const KService::Ptr service);}}
{{FeatureTodo|Move|  void loadRunner(const QString &path);}}
{{FeatureTodo|Move|  static KPluginInfo::List listRunnerInfo(const QString &parentApp;}}

{{FeatureDone|Keep|QMimeData * mimeDataForMatch(const QueryMatch &match) const;}}
{{FeatureDone|Keep|QMimeData * mimeDataForMatch(const QString &matchId) const;}}

{{FeatureTodo|Remove|slot void setupMatchSession(); -> Was done for the window runner, since xlib wasn’t threadsafe, Xcb is, so this can go}}
{{FeatureTodo|Remove|slot void matchSessionComplete(); -> Was done for the window runner, since xlib wasn’t threadsafe, Xcb is, so this can go}}

{{FeatureDone|Keep|slot void launchQuery(const QString &term, const QString &runnerId);}}
{{FeatureDone|Keep|slot void launchQuery(const QString &term);}}

{{FeatureTodo|Remove| bool execQuery(const QString &term, const QString &runnerName);}}
{{FeatureTodo|Remove| bool execQuery(const QString &term);}}
{{FeatureDone|Keep| slot void reset();}}
{{FeatureDone|Keep| void matchesChanged(const QList<Plasma::QueryMatch> &matches);}}
{{FeatureDone|Keep| void queryFinished();}}

|}